Skip to content

Fix misimplemented CountTimeWritable setter#96

Merged
xkrogen merged 2 commits into
linkedin:masterfrom
csgregorian:fix_counttimewritable_setter
Apr 4, 2019
Merged

Fix misimplemented CountTimeWritable setter#96
xkrogen merged 2 commits into
linkedin:masterfrom
csgregorian:fix_counttimewritable_setter

Conversation

@csgregorian

Copy link
Copy Markdown
Contributor

Somehow I defined the setter for CountTimeWritable as an adder in #92 without noticing.

facepalm

Also added docs in the README about the output file.

@xkrogen xkrogen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@xkrogen xkrogen merged commit 755a298 into linkedin:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants